Re: [libvirt] [Qemu-devel] [PATCH] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11

On 12.06.2018 00:18, Eduardo Habkost wrote: > On Mon, Jun 11, 2018 at 05:41:04AM +0200, Thomas Huth wrote: >> The oldest machine type which is still used in a maintained distribution >> is a pc-0.12 based machine type in RHEL6, so everything that is older >> than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10 >> and pc-0.11 so that we can finally remove them in a future release. [...] >> @@ -3952,6 +3953,10 @@ int main(int argc, char **argv, char **envp) >> } >> >> machine_class = select_machine(); >> + if (machine_class->deprecation_msg) { >> + error_report("Machine type '%s' is deprecated: %s", >> + machine_class->name, machine_class->deprecation_msg); >> + } > > Do you plan to add this info to 'query-machines' QMP command? No, I'm not planning to add this. We'd need a request from upper layers (i.e. libvirt) for this first, otherwise it's just a dead interface that nobody is using.