Re: [libvirt] [dbus PATCH 5/8] Implement GetAllDomainStats method for Connect Interface

On Thu, Apr 19, 2018 at 03:58:04PM +0200, Katerina Koukiou wrote: > Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com&gt; > --- > data/org.libvirt.Connect.xml | 7 +++++++ > src/connect.c | 40 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/data/org.libvirt.Connect.xml > b/data/org.libvirt.Connect.xml > index e5504f7..3ef965d 100644 > --- a/data/org.libvirt.Connect.xml > +++ b/data/org.libvirt.Connect.xml > @@ -94,6 +94,13 @@ > <arg name="flags" type="u" direction="in"/> > <arg name="storagePoolSources" type="s" direction="out"/> > </method> > + <method name="GetAllDomainStats"> > + <annotation name="org.gtk.GDBus.DocString" > + value="See https://libvirt.org/html/libvirt-libvirt-host.h > tml#virConnectGetAllDomainStats"/>; This one is documented in https://libvirt.org/html/libvirt-libvirt-do main.html#virConnectGetAllDomainStats Given that our API names are set in stone but our website URLs are not, maybe we need some stable link that would redirect to the correct doc page when given an API name.

Jano > + <arg name="stats" type="u" direction="in"/> > + <arg name="flags" type="u" direction="in"/> > + <arg name="records" type="av" direction="out"/> > + </method> > <method name="GetCapabilities"> > <annotation name="org.gtk.GDBus.DocString" > value="See https://libvirt.org/html/libvirt-libvirt-host.ht > ml#virConnectGetCapabilities"/>;