Re: [libvirt] [PATCH] Prevent streams from becoming libvirtd controlling TTY
On Wed, Mar 13, 2013 at 04:33:34PM -0600, Eric Blake wrote:
On 03/13/2013 11:24 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> When opening a stream to a device which is a TTY, that device
> may become the controlling TTY of libvirtd, if libvirtd was
> daemonized. This in turn means when the other end of the stream
> closes, libvirtd gets SIGHUP, causing it to reload its config.
> Prevent this by forcing O_NOCTTY on all streams that are opened
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> src/fdstream.c | 2 ++
> 1 file changed, 2 insertions(+)
ACK. Bet you had fun tracking down that dark corner of POSIX.
I can think of many appropriate words for what I had to do to
discover this. 'fun' is not one of them :-P
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|