Re: [libvirt] Patch replaces scriptlets with new systemd macros

> Then why are we explicitly starting cgconfig.service in the spec file? > Shouldn't the argument go that only those people customizing the service > file to use cgconfig need cgconfig enabled in the first place? In other > words, is there anything wrong with this one-liner? Oh that's probably a mistake then. We shouldn't be enabling it for systemd based installations. > > diff --git i/libvirt.spec.in w/libvirt.spec.in > index ebebfab..9d11328 100644 > --- i/libvirt.spec.in > +++ w/libvirt.spec.in > @@ -1465,13 +1465,12 @@ done > %endif > > %if %{with_systemd} > if [ $1 -eq 1 ] ; then > # Initial installation > /bin/systemctl enable libvirtd.service >/dev/null 2>&1 || : > - /bin/systemctl enable cgconfig.service >/dev/null 2>&1 || : > fi > %else > %if %{with_cgconfig} > # Starting with Fedora 16/RHEL-7, systemd automounts all cgroups, > # and cgconfig is no longer a necessary service. > %if (0%{?rhel} && 0%{?rhel} < 7) || (0%{?fedora} && 0%{?fedora} < 16) ACK