Re: [libvirt] [PATCH] qemu: Fix virsh freeze when blockcopy storage file is removed

On 12/03/2014 05:56 AM, Erik Skultety wrote: > If someone removes blockcopy storage file when still in mirroring phase That's fishy behavior on the part of the user. But since the patch is simple enough, it's still worth protecting ourselves from stupid users. > and then requesting blockjob abort using pivot, virsh cmd freezes. This > is not an issue with older qemu versions which did not support > asynchronous jobs (which we prefer by default). > As we have reached the mirroring phase successfully, polling monitor for > blockjob info always returns 1 and the loop never ends. > This fix introduces a check for qemuDomainBlockPivot return code, possibly > skipping the asynchronous waiting completely, if an error occured and s/occured/occurred/ > asynchronous waiting was the preferred method. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1139567 > --- > src/qemu/qemu_driver.c | 2 ++ > 1 file changed, 2 insertions(+) ACK.