Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

On Wed, Dec 03, 2008 at 06:52:32PM +0000, Daniel P. Berrange wrote: > On Wed, Dec 03, 2008 at 04:18:21PM +0100, Daniel Veillard wrote: > > On Mon, Dec 01, 2008 at 12:26:48AM +0000, Daniel P. Berrange wrote: > > > This is a diffstat summary for the combined series of 28 patches > > > > Okay, my take at this point is that those should be commited with > > the few fix found my manual examination, maybe extend the documentation > > a bit, and start testing it as much as prossible. > > Some locking debug facility might be a good addition, > > I wrote some an OCaml program using CIL to check driver method exit paths > and validate that all objects were left in an unlocked state. This found > some real bugs ! > > So here's the incremental fixes for those I was having so much fun I wrote more checks for incorrect locking order and data access while unlocked, and improved existing detection. A bunch more bugs found and fixed !