Re: [libvirt] [PATCH 2/5] virsh: Fix semantics of --config for "update-device" command

The man page states that with --config the next boot is affected. This can be understood as if _only_ the next bood was affected. This isn't

true if the machine is running. This patch adds the full --live, --config, --current infrastructure and tweaks stuff to correctly support the obsolete --persistent flag. --- tools/virsh-domain.c | 41 ++++++++++++++++++++++++++++++----------- tools/virsh.pod | 21 ++++++++++++++------- 2 files changed, 44 insertions(+), 18 deletions(-)

@@ -9267,7 +9275,22 @@ cmdUpdateDevice(vshControl *ctl, const vshCmd *cmd) const char *from = NULL; char *buffer = NULL; bool ret = false; - unsigned int flags; + unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; + bool current = vshCommandOptBool(cmd, "current"); + bool config = vshCommandOptBool(cmd, "config"); + bool live = vshCommandOptBool(cmd, "live"); + bool persistent = vshCommandOptBool(cmd, "persistent"); + + VSH_EXCLUSIVE_OPTIONS_VAR(persistent, live);

From my POV, I'd leave --persistent --live --config allowed. The change