Re: [libvirt PATCH v3 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED
On Mon, Apr 20, 2020 at 15:25:08 -0400, Tobin Feldman-Fitzthum wrote:
virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU
version is at least 2.10, KVM is enabled, and qom-list-types does
not include tcg-accel.
Signed-off-by: Tobin Feldman-Fitzthum <tobin(a)linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 8a17287076..9abc6e80e7 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2575,6 +2575,38 @@ virQEMUCapsProbeQMPGenericProps(virQEMUCapsPtr qemuCaps,
return 0;
}
+static int
+virQEMUCapsProbeQMPTCGState(virQEMUCapsPtr qemuCaps,
+ qemuMonitorPtr mon)
This is a static function which is not used in this patch. Thus the tree
would fail to compile after this patch which is not allowed accordign
to our contribution guidelines.
Please ensure that the tree compiles after every single patch.
Additionally as noted in review of patch 5 it's quite a waste to call
qemuMonitorGetObjectTypes again just to look for one string we've
already got before. You should implement this in
virQEMUCapsProbeQMPDevices by possibly renaming the function or just
adding the new flag to the array the function uses.