Re: [libvirt] [PATCH v2 04/12] qemu: domain: Assume 'raw' default storage format also for network storage
On Mon, Oct 08, 2018 at 07:10:28 -0400, John Ferlan wrote:
On 10/5/18 8:14 AM, Peter Krempa wrote:
> Post parse callback adds the 'raw' type only for local files. Remote
> files can also have backing store (even local) so we should do this also
> for network backed storage.
NIT: The .xml/.args in this patch are not all remote storage - they are
volume storage...
The disk-source-pool-mode.args gets the look/feel of remote from
virDomainDiskTranslateISCSIDirect
Oh! actually you are right. For disk type "VOLUME" we should not add any
default format in the parser since the function that fetches the volume
from the storage driver should do that.
I'll investigate slightly further and change the condition to only
exclude "VOLUME" disks rather than try to include a variety of the types
which require this.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)