Re: [PATCH] meson: Only check for openwsman if hyperv is enabled

On Fri, Aug 28, 2020 at 07:52:23 -0600, Jim Fehlig wrote: > On 8/28/20 2:00 AM, Pavel Hrdina wrote: >> On Thu, Aug 27, 2020 at 03:58:29PM -0600, Jim Fehlig wrote: >>> Running meson configure with '-Ddriver_hyperv=disabled' fails with >>> >>> meson.build:1252:0: ERROR: Dependency "openwsman" not found, tried >>> pkgconfig and cmake >>> >>> openwsman is only required if the hyperv driver is enabled. Don't >>> check for it if hyperv is disabled. >>> >>> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; >>> --- >>> >>> There are likely other ways to fix the problem, this being a meson >>> noobish one :-). >> >> You are probably using some other options as well because running: >> >> meson build -Ddriver_hyperv=disabled >> >> will not fail if openwsman is missing. The default for openwsman is >> 'auto'. > > I stumbled across it while doing downstream packaging work on 6.7.0. hyperv > is the only thing that requires openwsman and I have it disabled. Here's the > full meson invocation from the build log > > /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib64 > --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin > --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man > --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc > --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload > --auto-features=enabled . build --libexecdir=/usr/lib64/libvirt You've specified '--auto-features=enabled', so anything 'auto' is considered enabled in your build situation.