Re: [libvirt] [PATCH 07/10] conf: virDomainDiskDefIotuneParse: Report malformed number errors

On 04/12/2016 09:55 AM, Peter Krempa wrote: > Rest of the fields of the iotune data structure did not check for > malformed integers. Use the previously defined macro to extract them > which will simplify the code and add error reporting. > --- > src/conf/domain_conf.c | 50 ++++++++------------------------------------------ > 1 file changed, 8 insertions(+), 42 deletions(-) > ACK... we need more of these cleanups, there's way too much boilerplate in the codebase (he says as he just tried to add an extra 100 with setlocale error checking :) )