Re: [libvirt] [PATCH v5 09/10] virsh: implement new command for launch security

> > + }, > > + {.name = NULL} > > +}; > > + > > +static const vshCmdOptDef opts_launch_security[] = { > > + VIRSH_COMMON_OPT_DOMAIN_FULL(0), > > + {.name = "get", > > + .type = VSH_OT_STRING, > > + .help = N_("Show the launch-security info") > > + }, > > + VIRSH_COMMON_OPT_DOMAIN_CONFIG, > > + VIRSH_COMMON_OPT_DOMAIN_LIVE, > > + VIRSH_COMMON_OPT_DOMAIN_CURRENT, > > + {.name = NULL} > > +}; > > Sorry if I missed the obvious, but what exactly is the --get <string> supposed > to do? Giving it another thought, why do we need the virsh part anyway, this is only relevant for the config, aka shut off domain, so virsh edit and virsh dumpxml will do the job of a getter and a setter just fine, the main purpose of the virsh commands is to tune the 'live' configuration of a domain.