Re: [libvirt PATCH] qemu: reject readonly attribute for virtiofs
On Wed, May 13, 2020 at 11:34:05AM +0200, Andrea Bolognani wrote:
On Wed, 2020-05-13 at 10:58 +0200, Ján Tomko wrote:
> This is not yet supported by virtiofsd.
>
> Fixes #23
Please include the full URL here:
https://gitlab.com/libvirt/libvirt/-/issues/23
Using the '#23' format is the recommended way. GitLab UI will
turn it into a hyperlink, and automatically close the mentioned
issue.
> case VIR_DOMAIN_FS_DRIVER_TYPE_VIRTIOFS:
> + if (fs->readonly) {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("virtiofs does not yet supported read-only
mode"));
s/supported/support/
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|