Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

>>> As Laine and I discussed on IRC, I'm half wondering if we should >>> just do: >>> >>> #ifdef STATIC_ANALYSIS&& /* attributes supported */ >>> # define ATTRIBUTE_NONNULL(n) __attribute__((__nonnull__(n))) >>> #else >>> # define ATTRIBUTE_NONNULL(n) /* empty, due to gcc lameness */ >>> #endif >>> >>> so that our code will be pessimized under normal compiles, but _at >>> least_ places where we have bugs with improper use of the attribute >>> won't cause gcc to miscompile things; but still let us get NULL >>> checking >>> when running clang or Coverity. >>> >>> I also wonder if this has been detected by Coverity (checking a nonnull >>> parameter for NULL is dead code, which Coverity does tend to flag), and >>> we just haven't been following Coverity closely enough to notice. >> Eric, I ran Coverity on current commit 'f78024b util: fix crash when >> starting macvtap interfaces', >> Coverity hasn't complain this issue, although I also enabled >> '--security' checkers in Coverity. > The interesting run would be *before* this commit. I reran coverity on commit 'bae1312 build: fix bootstrap on RHEL', however, Coverity hasn't also complain the issue, for details, please refer to attachment.