Re: [libvirt] [jenkins-ci PATCH 16/17] osinfo-db: Build again on all machines

On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote: Here you need to add osinfo-db back to the various guests/host_vars/*/main.yml because they have been, correctly, removed in the meantime. Once again the syntax for the Jenkins part is wrong. Moreover, you're only changing the list of machines for the check job, but you should change the one in the top level instead, because now we can both build and check everywhere; notably, trying to do the latter without doing the former will certainly not work :) One last point: in the case of osinfo-db, which doesn't use Meson as its build system, we should now be able to build RPMs on all RPM-based operating systems. With all of the above addressed, Reviewed-by: Andrea Bolognani <abologna(a)redhat.com&gt; Your series is missing one more patch after this one, which does the same as the last few patches but for virt-manager. I think the test suite still can't work on CentOS 7 because it uses python3-libxml2 which is not present there - maybe it should be ported to python3-lxml? - but we should be able to at least build on that target, and other targets that got their virt-manager jobs disabled only on account of not having libosinfo can now have them fully restored. -- Andrea Bolognani / Red Hat / Virtualization