Re: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type

Hi Michal, On 01/08/2022 09:23, Michal Prívozník wrote: > On 7/29/22 17:50, Oleksandr Tyshchenko wrote: > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko(a)epam.com&gt; > > > > Xen toolstack has gained basic Virtio support recently which becides > > adding various virtio related stuff introduces new disk backend type > > LIBXL_DISK_BACKEND_STANDALONE [1]. > > > > Unfortunately, this caused a regression in libvirt build with Xen support > > enabled, reported by the osstest today [2]: > > > > CC libxl/libvirt_driver_libxl_impl_la-xen_xl.lo > > ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': > > ../../src/libxl/xen_xl.c:779:17: error: enumeration value 'LIBXL_DISK_BACKEND_STANDALONE' > > not handled in switch [-Werror=switch-enum] > > switch (libxldisk->backend) { > > ^~~~~~ > > cc1: all warnings being treated as errors > > > > The interesting fact is that switch already has a default branch (which ought > > to cover such new addition), but the error is triggered as -Wswitch-enum > > gives a warning about an omitted enumeration code even if there is a default > > label. > > This is expected and in fact working correctly. We want compiler to warn > us about enum members that are not handled in a switch() statement. For us this is treated as an error. Is it intended?