Re: [libvirt] [PATCH v1 2/2] command: Change virCommandAddEnv so it replaces existing environment variables.

On 09/24/2012 12:54 PM, Richard W.M. Jones wrote: Any new feature deserves tests; I'm pushing this under the trivial rule. diff --git c/tests/commandtest.c w/tests/commandtest.c index 930df5c..cba6cb6 100644 --- c/tests/commandtest.c +++ w/tests/commandtest.c @@ -331,7 +331,9 @@ static int test8(const void *unused ATTRIBUTE_UNUSED) { virCommandPtr cmd = virCommandNew(abs_builddir "/commandhelper"); + virCommandAddEnvString(cmd, "USER=bogus"); virCommandAddEnvString(cmd, "LANG=C"); + virCommandAddEnvPair(cmd, "USER", "also bogus"); virCommandAddEnvPair(cmd, "USER", "test"); if (virCommandRun(cmd, NULL) < 0) { -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org