Re: [libvirt] PATCH: Another attempt to fix vbox driver open
On Mon, May 11, 2009 at 04:27:36PM +0200, Daniel Veillard wrote:
On Fri, May 08, 2009 at 05:42:07PM +0100, Daniel P. Berrange wrote:
[...]
> + if (conn->uri == NULL ||
> + conn->uri->scheme == NULL ||
> + STRNEQ (conn->uri->scheme, "vbox") ||
> + conn->uri->server != NULL)
> + return VIR_DRV_OPEN_DECLINED;
Hum, we accept NULL to indicate Xen or KVM/QEmu by default.
Maybe if none of them is available, we should allow NULL to start
the VirtualBox driver. It could be useful say on MacOS, or
just if VirtualBox is installed on Linux while we know KVM is not.
This block of code is in the vboxOpenDummy() function. In this scenario
we have already determined that the VirtualBox RPC libraries are not
available. Hence there is no need to perform a probe when uri == NULL
here.
The other "real" vboxOpen() method you noticed later in the patch do
still handle NULL
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|