Re: [libvirt] [PATCH] udev: Don't try to dump DMI on non-intel archs

On 07/20/2011 08:54 AM, Michal Privoznik wrote: >> -#ifdef WIN32 >> +#if defined(WIN32) || \ >> + defined(__x86_64__) || \ >> + defined(__i386__) || \ >> + defined(__amd64__) >> > In fact, we need a patch with complement condition: Doh, serves me right for typing without testing. > > diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c > index 2c8e687..6625cae 100644 > --- a/src/util/sysinfo.c > +++ b/src/util/sysinfo.c > @@ -113,7 +113,10 @@ void virSysinfoDefFree(virSysinfoDefPtr def) > * > * Returns: a filled up sysinfo structure or NULL in case of error > */ > -#ifdef WIN32 > +#if defined(WIN32) || \ > + !(defined(__x86_64__) || \ > + defined(__i386__) || \ > + defined(__amd64__)) Much nicer. > > With this patch we transfer to error: > 10:51:36.515: 4412: error : virSysinfoRead:127 : Host sysinfo extraction > not supported on this platform: Function not implemented > > I think this is the right way of dealing with this, isn't it? Yes, that looks nicer. ACK to committing this as a patch.