Re: [libvirt PATCH 00/51] Use permutable format strings in translations

On Fri, Mar 10, 2023 at 05:09:16PM +0100, Jiri Denemark wrote: > See 01/51 for rationale. Enforced by the last two patches of this > series. The rest is quite boring mechanical update, partially done using > a perl oneliner > > perl -pe 'for (my $i=1; $i<=12; $i++) { s/(N?_\("[^"]*?%)([^%$ ]*[a-zA-Z][^"]*")/\1$i\$\2/; }' > > and tuned manually to fix cases not covered by the regexp above and to > merge multiline messages into a single line. I merged only those that > were touched anyway. Some very long messages consisting of several > sentences were merged only partially and split on sentence boundary. > > I will also update libvirt.pot once this is pushed. Are we *100% sure* weblate is going to handle this intelligently. This will change almost all of the msgid strings in libvirt.pot, and translations are associatd with msgid strings. IOW, this risks throwing all our translations away putting us back to near zero translation coverage, unless weblate is intelligent enough to map numbered format strings, to non-numbered format strings, and I'm not convinced that it can do that.