Re: [libvirt] [PATCH] virBitmapFree: Change the function to a macro

>>>> Yes，it's an actual crash problem. I found the problem in the above > problem >>> scenario in my first mail.

> > A problem scenario: > 1) The XML of VM contain the below segment: > <numatune> > <memory mode='preferred' placement='auto' nodeset='0'/> > </numatune> > 2)virsh create the VM > 3)In the virDomainDefParseXML funtion: > /* Ignore 'nodeset' if 'placement' is 'auto' finally */ > if (placement_mode == VIR_NUMA_TUNE_MEM_PLACEMENT_MODE_AUTO) { > virBitmapFree(def->numatune.memory.nodemask); > def->numatune.memory.nodemask = NULL; > } > 4)Then, virsh destroy the VM. In the virDomainDefFree funtion, it also call the > virBitmapFree function to free the nodemask: > virBitmapFree(def->numatune.memory.nodemask);

>>> >>> Then can you send a patch which explicitly fixes that problem on its >>> own, without doing this major refactoring, which obscures what is being >>> fixed. >> >> I had sent a patch in my first mail. You can find the mail at the following links: >> > https://www.redhat.com/archives/libvir-list/2013-September/msg00337.html > > No, I want the root cause fixed. This change to the bitmap APIs is just > papering over any root cause bug. > This is a simple problem about an address is released twice in some scenario. I think that released twice is the root cause. I'm not sure what you mean about root cause. Did you mean that why the address will be released two times?