Re: [libvirt] [PATCH] tests: env perl shebang for test-wrap-argv.pl
On 08.07.2016 20:47, Fabian Freyer wrote:
On some systems perl is not necessarily in /usr/bin/perl. Use the
perl version
in the PATH instead.
---
tests/test-wrap-argv.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-wrap-argv.pl b/tests/test-wrap-argv.pl
index d66f5b4..b053f28 100755
--- a/tests/test-wrap-argv.pl
+++ b/tests/test-wrap-argv.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/env perl
#
# Copyright (C) 2015 Red Hat, Inc.
#
Oh, right. My bad. But there are some other occurrences, for instance:
libvirt.git $ for i in $(find . -type f -iname "*.pl" ); do echo -n "$i:
" && head -n1 $i; done
./docs/genaclperms.pl: #!/usr/bin/perl
./docs/hvsupport.pl: #!/usr/bin/perl
./docs/todo.pl: #!/usr/bin/perl
./src/access/genpolkit.pl: #!/usr/bin/perl
./src/check-symfile.pl: #!/usr/bin/perl
./src/dtrace2systemtap.pl: #!/usr/bin/perl
./src/rpc/gendispatch.pl: #!/usr/bin/perl -w
./src/rpc/gensystemtap.pl: #!/usr/bin/perl
./src/rpc/genprotocol.pl: #
./src/check-aclperms.pl: #!/usr/bin/perl
./src/check-symsorting.pl: #!/usr/bin/perl
./src/check-driverimpls.pl: #!/usr/bin/perl
./src/check-drivername.pl: #!/usr/bin/perl
./src/check-aclrules.pl: #!/usr/bin/perl
./tests/check-file-access.pl: #!/usr/bin/perl -w
./tests/oomtrace.pl: #!/usr/bin/perl
Would you mind fixing those too?
Meanwhile, I'm pushing this one.
Michal