Re: [libvirt] [PATCH 1/2] docs: move javascript logic into a standalone file
On Fri, 2019-04-05 at 14:30 +0100, Daniel P. Berrangé wrote:
Instead of duplicating javascript in every single page, put it in a
standalone file which can be cached by the browser.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
docs/main.js | 25 +++++++++++++++++++++++++
docs/page.xsl | 35 +++--------------------------------
2 files changed, 28 insertions(+), 32 deletions(-)
create mode 100644 docs/main.js
Don't we need to add the new file to docs/Makefile.am so that it's
included in release archives and... Possibly installed?
I'm actually unclear on how we handle this kind of content :)
The change itself looks good though.
--
Andrea Bolognani / Red Hat / Virtualization