Re: [libvirt] [PATCH] tests: More unit tests for internal hash APIs

On 04/19/2011 07:22 AM, Jiri Denemark wrote: > This adds several tests for remaining hash APIs (custom > hasher/comparator functions are not covered yet, though). > > All tests pass both before and after the "Simplify hash implementation". > --- > src/util/hash.c | 18 +++ > src/util/hash.h | 1 + > tests/hashdata.h | 237 +++++++++++++++++++++++++++++++++++- > tests/hashtest.c | 361 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 615 insertions(+), 2 deletions(-) Overall, this looks like a good patch; the fact that it passes 'make check' speaks highly, and it is some good additional coverage. ACK with nits fixed.