Re: [libvirt] [PATCH] esx: Move username and password helper functions to util.c
On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote:
---
src/esx/esx_driver.c | 8 ++--
src/esx/esx_util.c | 83 ----------------------------------------------
src/esx/esx_util.h | 7 ----
src/util/util.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/util/util.h | 5 +++
5 files changed, 98 insertions(+), 94 deletions(-)
ACK in principle, but I think we should start a new file for these helpers,
rather than continue to add more to 'util.c' since it is getting rather large.
Lets keep util.c/h for POFIX file/path/process related wrappers.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|