Re: [libvirt] [PATCH] esx: Generate implicit _this macros
2011/5/13 Eric Blake <eblake(a)redhat.com>:
On 05/01/2011 01:57 PM, Matthias Bolte wrote:
> ---
> src/Makefile.am | 1 +
> src/esx/esx_vi_generator.py | 48 ++++++++++++++++++++++++------------------
> src/esx/esx_vi_methods.c | 40 +++--------------------------------
> 3 files changed, 32 insertions(+), 57 deletions(-)
I'm not sure I completely understand what this patch was trying to do,
but it compiles fine, and seems like it is moving code from special case
over to generated, which hopefully makes future extensions (aka the rest
of your series) use less effort.
Maybe a commit comment will help someone reading 'git log' down the road.
True, here's what I've added:
Several vSphere API methods are called on global objects like the
FileManager, the PerformanceManager or the SearchIndex. The generator
input file allows to mark such methods and the generator generates
such method in a way that automatically handles marked parameter. This
is done by some special macros. Those were manually written and this
patch moves them to the generator.
ACK.
Thanks, pushed.
Matthias