Re: [libvirt] [PATCH 3/6] Update XML Schema for new entries.

On 02/07/2011 11:58 PM, Gui Jianfeng wrote: Subject line could use 'cgroups:' lead-in. Why all caps? As long as we're touching this area of the file, s/shoul/should/ ACK with this squashed in: diff --git i/docs/schemas/domain.rng w/docs/schemas/domain.rng index a9391d3..7fe66e3 100644 --- i/docs/schemas/domain.rng +++ w/docs/schemas/domain.rng @@ -312,7 +312,7 @@ <!-- I/O weight the VM can use --> <optional> <element name="weight"> - <ref name="WEIGHT"/> + <ref name="weight"/> </element> </optional> </element> @@ -2159,10 +2159,10 @@ Type library Our unsignedInt doesn't allow a leading '+' in its lexical form - A domain name shoul be made of ascii, numbers, _-+ and is non-empty + A domain name should be made of ascii, numbers, _-+ and is non-empty UUID currently allows only the 32 characters strict syntax memoryKB request at least 4Mbytes though Xen will grow bigger if too low - WEIGHT currently is in range [100, 1000] + weight currently is in range [100, 1000] --> <define name="unsignedInt"> <data type="unsignedInt"> @@ -2195,7 +2195,7 @@ <param name="minInclusive">-1</param> </data> </define> - <define name="WEIGHT"> + <define name="weight"> <data type="unsignedInt"> <param name="pattern">[0-9]+</param> <param name="minInclusive">100</param> -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org