Re: [libvirt] [PATCH V2] virpci: support driver_override sysfs interface

On 08/30/2016 11:59 PM, Laine Stump wrote: > On 08/01/2016 11:36 PM, Jim Fehlig wrote: >> libvirt uses the new_id PCI sysfs interface to bind a PCI stub driver >> to a PCI device. The new_id interface is known to be buggy and racey, >> hence a more deterministic interface was introduced in the 3.12 kernel: >> driver_override. For more details see >> >> https://www.redhat.com/archives/libvir-list/2016-June/msg02124.html > That message details the change to the kernel that caused the regression for > Xen, but not the driver_override interface. Maybe you could add a link to the > kernel commit that adds driver_override: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/dr... Yep, good point. Nice to have a description of the interface and examples of its use. I'll add it to the commit messages. > > > Everything else looks good, and passes my tests for vfio device assignment > (including when the host driver has been blacklisted). > > ACK. (Sorry I forgot about this earlier in the month :-/) Thanks! I'll wait until 2.2.0 is out before pushing this.