Re: [libvirt] [PATCH] build: Fix AUTHORS generation

On 12/14/2012 08:19 AM, Jiri Denemark wrote: > Using s/#authorslist#/$$out/ makes perl eat @domain part of all email > addresses from $out since it tries to interpret them as array variables. > I'm not sure if we can escape those in s/// but I know we can use print: > > s/#authorslist#// and print '$$out' > > to tell perl not to even inside $out. > > This patch also fixes gen-AUTHORS so that it works in VPATH. > --- > Makefile.am | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > gen-AUTHORS: > - $(AM_V_GEN)if test -d .git; then \ > - out="`git log --pretty=format:'%aN <%aE>' | sort -u`" && \ > - cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#/$$out/" > \ > + $(AM_V_GEN)if test -d $(srcdir)/.git; then \ > + out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \ > + cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#// and print '$$out'" > \ ACK, although this would be a nice time to fix the useless use of cat: perl -p -e "s/#authorslist#// and print '$$out'" \ < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \