Re: [Libvir] [PATCH] remove useless tests before xmlFree
On Tue, Apr 29, 2008 at 09:44:50PM +0200, Jim Meyering wrote:
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> On Tue, Apr 29, 2008 at 09:30:39PM +0200, Jim Meyering wrote:
>> I've just fixed a bug in my useless-if-detecting script,
>> committed in gnulib. Using that new script with today's
>> change adding xmlFree to the list exposed a bunch of useless tests.
>> This first change set removes those tests.
>>
>> Below it is a separate patch that updates gnulib-related
>> files, including that script and vc-list-files.
>> I verified that with these changes "make distcheck" passes.
>>
>> If no one objects, I'll push these in about 12 hours.
>>
>> remove useless tests before xmlFree
...
> ACK, please commit .
Ok. I've just done that one.
The gnulib one will take a couple more minutes.
I think one of the files from the gnulib refresh got missed from the
commit
[berrange@t60wlan libvirt-new]$ make
make all-recursive
make[1]: Entering directory `/home/berrange/src/xen/libvirt-new'
Making all in gnulib/lib
make[2]: Entering directory `/home/berrange/src/xen/libvirt-new/gnulib/lib'
{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
cat ./alloca.in.h; \
} > alloca.h-t
mv -f alloca.h-t alloca.h
/bin/mkdir -p arpa
rm -f arpa/inet.h-t arpa/inet.h
{ echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \
sed -e 's/@''INCLUDE_NEXT''@/include_next/g' \
-e 's|@''NEXT_ARPA_INET_H''(a)|<arpa/inet.h>|g'
\
-e 's|@''HAVE_ARPA_INET_H''@|1|g' \
-e 's|@''GNULIB_INET_NTOP''@|1|g' \
-e 's|@''GNULIB_INET_PTON''@|0|g' \
-e 's|@''HAVE_DECL_INET_NTOP''@|1|g' \
-e 's|@''HAVE_DECL_INET_PTON''@|1|g' \
< ./arpa_inet.in.h; \
} > arpa/inet.h-t
/bin/sh: line 1: ./arpa_inet.in.h: No such file or directory
make[2]: *** [arpa/inet.h] Error 1
make[2]: Leaving directory `/home/berrange/src/xen/libvirt-new/gnulib/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/berrange/src/xen/libvirt-new'
make: *** [all] Error 2
Regards,
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|