Re: [PATCH libvirt v2 0/5] Fix zPCI address auto-generation on s390
On Fri, 2020-06-26 at 14:13 +0200, Shalini Chellathurai Saroja wrote:
On 6/25/20 8:01 PM, Andrea Bolognani wrote:
> Aside from the comments in patch 2/5, everything looks good to me.
>
> The series does, however, not update the release notes (NEWS.rst):
> can you please post a 6/5 patch that takes care of that, assuming we
> decide not to go with a respin?
Hi Andrea,
Thank you :-). I have attached the patch to update the release notes
with this email.
Thanks. I tweaked the commit message a bit, and I also had to squash
the diff below into patch 2 to make CentOS 7 and macOS happy. The
series is now pushed. Have a nice weekend :)
diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c
index 21398e90f2..64a713a5f9 100644
--- a/src/conf/device_conf.c
+++ b/src/conf/device_conf.c
@@ -52,7 +52,7 @@ static int
virZPCIDeviceAddressParseXML(xmlNodePtr node,
virPCIDeviceAddressPtr addr)
{
- virZPCIDeviceAddress def = { 0 };
+ virZPCIDeviceAddress def = { .uid = { 0 }, .fid = { 0 } };
g_autofree char *uid = NULL;
g_autofree char *fid = NULL;
--
Andrea Bolognani / Red Hat / Virtualization