Re: [libvirt] [PATCH 04/17] graphics: generate fake ports also for tests
On Thu, May 05, 2016 at 18:20:23 +0200, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/qemu/qemu_driver.c | 12 ------------
src/qemu/qemu_process.c | 13 +++++++++++++
tests/qemuxml2argvdata/qemuxml2argv-controller-order.args | 2 +-
tests/qemuxml2argvdata/qemuxml2argv-hugepages-numa.args | 2 +-
.../qemuxml2argv-video-device-pciaddr-default.args | 2 +-
5 files changed, 16 insertions(+), 15 deletions(-)
While I'm okay by this change itself I don't really see a reason why
qemuProcessSPICEAllocatePorts and qemuProcessVNCAllocatePorts should be
called in two distinct places. With the new helpers I think we have the
facility to select the @alloc parameter according to the
VIR_QEMU_PROCESS_START_PRETEND flag and call it just once.
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)