Re: [libvirt] [PATCH 1/4] snapshot: add two more filter sets to API

On 11/13/12 20:09, Eric Blake wrote: > As we enable more modes of snapshot creation, it becomes more important > to be able to quickly filter based on snapshot properties. This patch > introduces new filter flags; subsequent patches will introduce virsh > back-compat filtering, as well as actual libvirt filtering. >

> +++ b/include/libvirt/libvirt.h.in > @@ -3818,6 +3818,25 @@ typedef enum { > which have > metadata */ > VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA = (1 << 4), /* Filter by > snapshots > with no > metadata */ > + > + VIR_DOMAIN_SNAPSHOT_LIST_OFFLINE = (1 << 5), /* Filter by > snapshots > + taken while > guest was > + offline */ > + VIR_DOMAIN_SNAPSHOT_LIST_ONLINE = (1 << 6), /* Filter by > snapshots > + taken while > guest was > + online, and with > + memory state */ I'm wondering if we shouldn't go for ACTIVE/INACTIVE here?

Otherwise looks okay so I'm comfortable with ACKing this when the naming question gets settled.