Re: [libvirt] [PATCH] Allow comma separated list of shutdown/reboot modes with virsh
On Fri, Nov 30, 2012 at 11:05:25AM -0500, Eric Blake wrote:
> The shutdown and reboot commands in virsh allow a comma
> separated list of mode values
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
> ---
> tools/virsh-domain.c | 25 +++++++++++++++++++++++--
> tools/virsh.pod | 16 ++++++++++++----
> 2 files changed, 35 insertions(+), 6 deletions(-)
>
> - if (mode) {
> + if (!(modes = virStringSplit(mode, ",", 0))) {
Any reason you can't use vshStringToArray to do the split?
I didn't know it existed - utility functions like that shouldn't
be in virsh code anyway. Now I know it exists, I'll kill it off
in favour of virStringSplit everywhere.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|