28 Apr
2020
28 Apr
'20
10:20 a.m.
On Tue, Apr 28, 2020 at 09:34:54AM +0200, Andrea Bolognani wrote:
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote:
@@ -617,7 +591,7 @@ class Application: def _action_install(self, args): base = Util.get_base()
- flavor = self._config.get_flavor() + flavor = self._config.dict["install"]["flavor"]
You can remove this assignment and just use the value directly below, like you've done in _execute_playbook().
Okay, missed that one.
There are also two uses of get_flavor() remaining after this patch:
get_gitlab_runner_token_file() get_gitlab_url_file()
Yeah, does it matter since I'm dropping those 2 patches later? -- Erik Skultety