Re: [libvirt] [PATCH v2] qemu: Don't lose group_name

On 26.01.2017 15:38, Martin Kletzander wrote: > On Wed, Jan 25, 2017 at 03:53:20PM +0100, Martin Kletzander wrote: >> Due to our APIs not copying various pointers, we need to carry it >> around on the side and just supply it every time it is needed. >> Otherwise it will not work with both --live and --config options. >> >> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; >> --- >> src/qemu/qemu_driver.c | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> > > Scratch this, this needs some fixes as well, but trivial ones, so this > whole series is on branch blkdeviotune on my github now > https://github.com/nertpinx/libvirt/tree/blkdeviotune > While it would be nice to send the patches to the list as another version, this has undergone more rounds than needed. ACK to the patches on your branch. There are still some problems (e.g. in "qemu: Don't lose group_name" - we firstly free() and then try to strdup() which can lead to losing the original value if strdup() fails), but those can be fixed after your patches are pushed.

Michal