Re: [libvirt] [PATCH 41/41] libvirt: correctly print out URI returned from probing
On Mon, 2019-07-29 at 14:34 +0200, Andrea Bolognani wrote:
On Tue, 2019-07-23 at 17:03 +0100, Daniel P. Berrangé wrote:
> Turning a NULL URI instead the empty string is very misleading when
> reading the debug logs as the distinction between the two is
> functionally important.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> src/libvirt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks like it could have been waaay earlier in the series, or
even pushed trivially outside of it... I guess you wanted to have a
little treat for whoever made it to the end of the series! :)
Looking forward to v3!
And of course I forgot the most important bit:
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization