Re: [libvirt] [PATCH] util: Fix broken MinGW builds caused by commit 9bc01ad8

On Fri, Jul 19, 2019 at 08:39:35AM +0200, Peter Krempa wrote: > On Fri, Jul 19, 2019 at 08:30:34 +0200, Erik Skultety wrote: > > virPCIGetSysfsFile is conditionally compiled only on Linux platforms. > > > > Signed-off-by: Erik Skultety <eskultet(a)redhat.com&gt; > > --- > > > > Pushed under the build breaker rule. > > > > src/util/virpci.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/util/virpci.c b/src/util/virpci.c > > index 75e8daadd5..ae3a0fa886 100644 > > --- a/src/util/virpci.c > > +++ b/src/util/virpci.c > > @@ -3099,6 +3099,14 @@ virPCIGetVirtualFunctionIndex(const char *pf_sysfs_device_link ATTRIBUTE_UNUSED, > > > > } > > > > +int > > +virPCIGetSysfsFile(char *virPCIDeviceName ATTRIBUTE_UNUSED, > > + char **pci_sysfs_device_link ATTRIBUTE_UNUSED) > > +{ > > + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); > > I think you forgot quotes around the "unsupported" string. unsupported is a const char * variable.