Re: [libvirt] PATCH: 2/12: Make use of versioned linker scripts
On Thu, Nov 13, 2008 at 05:21:23PM +0000, Daniel P. Berrange wrote:
This patch changes the way we use linker scripts to have fully
versioned
symbols, and a versioned private section for symbols needed by libvirtd
and virsh.
Just a couple of questions:
+++ b/src/driver.h Tue Nov 11 17:28:31 2008 +0000
@@ -73,7 +73,7 @@
typedef int
(*virDrvClose) (virConnectPtr conn);
typedef int
- (*virDrvSupportsFeature) (virConnectPtr conn, int feature);
+ (*virDrvDrvSupportsFeature) (virConnectPtr conn, int feature);
I miss the point ... err why ?
...]
diff -r bbf3d0bc9d49 src/libvirt_sym.version.in
[...]
+LIBVIRT_0.5.0 {
+ global:
+ virDomainCreateXML;
+ virEventRegisterImpl;
+ virConnectDomainEventRegister;
+ virConnectDomainEventDeregister;
+} LIBVIRT_0.4.5;
+
+/* .... define new API here using predicted next version number .... */
So basically as part of doing a release I should guess the new version
number and make a template empty section here, commited after tagging
the release.
Looks fine to me, and we need this, +1
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/