Re: [libvirt] PATCH: Remove qemudLog() macro, use logging.h instead

Daniel P. Berrange wrote: > The qemudLog() macro just spews its messages to stderr. This patch changes > it to use the proper logging.h APIs, so the output channel is configurable > in the expected way. Looks good. Considering the preceding comment, and since you didn't mention this sole WARN->ERROR change, I wonder if it was deliberate: > diff --git a/src/qemu_conf.c b/src/qemu_conf.c ... > /* Check & log unexpected exit status, but don't fail, > * as there's really no need to throw an error if we did > * actually read a valid version number above */ > if (WEXITSTATUS(status) != 0) { > - qemudLog(QEMUD_WARN, > - _("Unexpected exit status '%d', qemu probably failed"), > - WEXITSTATUS(status)); > + VIR_ERROR(_("Unexpected exit status '%d', qemu probably failed"), > + WEXITSTATUS(status)); > }