Re: [libvirt] [PATCH v2 1/1] Set legacy USB option with default for ppc64.

On Mon, Apr 15, 2013 at 09:12:18PM +0800, Li Zhang wrote: > From: Li Zhang <zhlcindy(a)linux.vnet.ibm.com&gt; > > Currently, -device xxx still can't work well for ppc64 platform. > It's better use legacy USB option with default for ppc64. > > This patch is to legacy USB option with default for ppc64. > > Signed-off-by: Li Zhang <zhlcindy(a)linux.vnet.ibm.com&gt; > --- > > v2 -> v1: > * Add test cases for USB controller configuration on PPC64. > > src/qemu/qemu_command.c | 3 ++- > .../qemuxml2argv-pseries-usb-default.args | 1 + > .../qemuxml2argv-pseries-usb-default.xml | 17 +++++++++++++++++ > .../qemuxml2argv-pseries-usb-multi.args | 1 + > .../qemuxml2argv-pseries-usb-multi.xml | 19 +++++++++++++++++++ > tests/qemuxml2argvtest.c | 8 ++++++++ > 6 files changed, 48 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-default.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-default.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-multi.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-multi.xml ACK, I have pushed this now

> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-default.args b/tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-default.args > new file mode 100644 > index 0000000..745910b > --- /dev/null > +++ b/tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-default.args > @@ -0,0 +1 @@ > +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu-system-ppc64 -S -M pseries -m 512 -smp 1 -nographic -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/tmp/test-monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=readline -no-acpi -boot c -usb -chardev pty,id=charserial0 -device spapr-vty,chardev=charserial0,reg=0x30000000 In future please ensure these files are line wrapped to 80 colums - I modified this when I pushed it to get rid of the long lines.

Daniel