Re: [libvirt] [PATCH] logging: pass binary name not logfile name when enabling logging
On Thu, Jul 18, 2019 at 05:14:13PM +0200, Ján Tomko wrote:
On Thu, Jul 18, 2019 at 03:53:32PM +0100, Daniel P. Berrangé wrote:
> Ping
>
> On Mon, Jul 08, 2019 at 03:13:09PM +0100, Daniel P. Berrangé wrote:
> > Instead of having each caller pass in the desired logfile name, pass in
> > the binary name instead. The logging code can then just derive a logfile
> > name by appending ".log".
> >
> > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> > ---
> > src/locking/lock_daemon.c | 2 +-
> > src/logging/log_daemon.c | 2 +-
> > src/remote/remote_daemon.c | 2 +-
> > src/util/virlog.c | 20 ++++++++++----------
> > 4 files changed, 13 insertions(+), 13 deletions(-)
> >
IIUC this was:
Acked-by: Michal Privoznik <mprivozn(a)redhat.com>
as a part of the daemon split series
https://www.redhat.com/archives/libvir-list/2019-July/msg00799.html
Oh, whoops, I forgot that I had it as part of that large series too.
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|