Re: [libvirt] [PATCH v2] nwfilter: Tear down temp. filters when tearing all filters

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; To: Stefan Berger/Watson/IBM@IBMUS, Cc: libvirt-list(a)redhat.com, Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; Date: 04/30/2014 12:41 PM Subject: Re: [PATCH v2] nwfilter: Tear down temp. filters when tearing all filters On Wed, Apr 30, 2014 at 12:30:01PM -0400, Stefan Berger wrote: > From: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > > Refactor the ebiptablesTearNewRules function so that the teardown of temporary > filters can also be called by the ebiptablesAllTeardown function. > > This fixes a problem that leaves temporary filters behind when a VM shuts down > while its filters are modified. > > Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > > v1->v2: > - test cases adjusted to expect more commands > --- > src/nwfilter/nwfilter_ebiptables_driver.c | 24 ++++++++---- > tests/nwfilterebiptablestest.c | 64 ++++++++++++++++ +-------------- > 2 files changed, 52 insertions(+), 36 deletions(-) ACK