Re: [libvirt] [PATCH v2 05/13] qemu: remove writing to QEMU log file for rename operation
On 11/12/2015 12:19 PM, Daniel P. Berrange wrote:
The rename operation only works on inactive virtual machines,
but it none the less writes to the log file used by the QEMU
processes. This log file is not intended to provide a general
purpose audit trail of operations performed on VMs. The audit
subsystem has recording of important operations. If we want
to extend that to cover all significant public APIs that is
a valid thing to consider, but we shouldn't arbitrarily log
specific APIs into the QEMU log file in the meantime.
Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
---
src/qemu/qemu_driver.c | 28 ----------------------------
1 file changed, 28 deletions(-)
Seems reasonable. Of course one could have "renamed" the log file to
use the new name in order to keep all the history of the same machine
(the uuid seems to remain constant).
ACK -
John