Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check
On Mon, 2018-07-23 at 10:27 +0100, Daniel P. Berrangé wrote:
On Mon, Jul 23, 2018 at 09:38:47AM +0200, Andrea Bolognani wrote:
> Partially answering myself (morning coffee hasn't quite kicked in
> just yet), the MinGW .spec doesn't list yajl as a BuildRequires,
> which means that either we're not hitting any of the code paths you
> mention on that platform, or we've been producing completely useless
> Windows builds for a while now :)
The remote driver works fine without JSON being required.
That being the case, not having jansson as mandatory sounds like the
proper thing to do, at least from the theoretical point of view: even
if you build without it, you can still get *some* functionality out
of libvirt, so it's kinda hard to argue for it being a strict
requirement the same way something like libxml2 is.
--
Andrea Bolognani / Red Hat / Virtualization