Re: [libvirt] [PATCH] (updated) additional parameters needed for dnsmasq

On 08/22/2012 10:59 AM, Gene Czarcinski wrote: This message needs adjustment before it is appropriate for libvirt.git (a year from now, someone reading 'git log' will have no idea what it was '(updated)' from, nor know the URL to the 'previous message'). Simpler as: if (network->def->domain) virCommandArgPair(cmd, "--domain", network->def->domain); virCommandAddArgFormat(cmd, "--local=/%s/", network->def->domain ? network->def->domain : ""); virCommandAddArgList(cmd, "--domain-needed", "--filterwin2k", NULL); with a corresponding tweak in the testsuite to recognize '--domain=example.com' as a result. Thanks, that helped. Your mail failed to make it through 'git am', but your attachment made it through 'git apply' so I was still able to piece the two together to form the commit message using the headers from your email for correct attribution. But using 'git send-email' in the future would make it easier to apply your patches; we have some hints on that in our HACKING file. ACK and pushed with the above tweak, and with adding you to AUTHORS (let us know if you prefer any other spelling or email address; the file is in UTF-8). -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org