Re: [libvirt] [PATCH V2 3/4] Parse lists of values
On 10/24/2011 09:55 AM, Daniel P. Berrange wrote:
On Mon, Oct 24, 2011 at 09:08:44AM -0400, Stefan Berger wrote:
> This patch introduces a parser for parsing lists of values as for example
> found in the XML here:
>
> <parameter name='TEST' value='[10.1.2.3,10.2.3.4,
10.1.1.1]'/>
>
> The list of values is then stored in the newly introduced data type
> virNWFilterVarValue.
This kind of thing is frowned up with XML, because now everything that
uses the XML doc has todo special parsing. eg, you can't just use a
XPath query to get a list of IP values as a nodeset, instead you have
to query for a node and then post-process it. Why not just support
<parameter name='TEST' value='10.1.2.3'/>
<parameter name='TEST' value='10.2.3.4'/>
<parameter name='TEST' value='10.1.1.1'/>
Ok, I'll modify it to support this.
Stefan
Regards,
Daniel