Re: [libvirt] [PATCH 08/22] Introduce virConnectCompareHypervisorCPU public API

>> + if (ret == VIR_CPU_COMPARE_ERROR) >> + goto error; > > Admittedly I did not look too closely, but will the compareHypervisorCPU functions actually > return "VIR_CPU_COMPARE_ERROR" on error? If so, wouldn't it be more sensible to return a > "VIR_HYPERVISOR_CPU_COMPARE_ERROR" instead? The function returns a value from enum virCPUCompareResult just like the original connectCompareCPU API. I don't see a reason for introducing a new set of return values for the new connectCompareHypervisorCPU.