Re: [libvirt] [PATCH 3/3] libxl: add .domainSendKey

On Tue, Dec 09, 2014 at 11:27:46AM +0800, Chunyan Liu wrote: I think this is really bending the semantics of the virDomainSendKey API too much. This API is documented to inject *any* scancodes into the guest operating system. Implementing it in such a way that you can only send sysrq key sequences to the guest kernel is not what applications will expect when they try to use this API. So NACK to this patch I'm open to the idea of adding an explicit API for triggering the sysrq sequence though. eg virDomainSendSysRequest or something like that, if you really want access to sysrq via the API. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|