Re: [libvirt] [PATCH 1/3] syntax-check: Don't include public headers in internal source
On 04/17/2013 04:19 AM, Osier Yang wrote:
Directories python/tools/examples should include them in <>
form,
though this patch allows "" form in these directories by excluding
them, a later patch will do the cleanup.
Looks like a bit of a mishap while sending; this comes after the email
titled:
[1/4] syntax-check: Don't include duplicate header
---
cfg.mk | 10 ++++++++++
daemon/remote.c | 2 --
src/libvirt-qemu.c | 1 -
3 files changed, 10 insertions(+), 3 deletions(-)
The syntax check is okay.
+++ b/daemon/remote.c
@@ -38,8 +38,6 @@
#include "virutil.h"
#include "stream.h"
#include "viruuid.h"
-#include "libvirt/libvirt-qemu.h"
-#include "libvirt/libvirt-lxc.h"
Fine; indirectly included by libvirt_internal.h which pulls in internal.h.
#include "vircommand.h"
#include "intprops.h"
#include "virnetserverservice.h"
diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c
index 11da2f3..fb19584 100644
--- a/src/libvirt-qemu.c
+++ b/src/libvirt-qemu.c
@@ -26,7 +26,6 @@
#include "virerror.h"
#include "virlog.h"
#include "datatypes.h"
-#include "libvirt/libvirt-qemu.h"
Also fine; virerror.h includes internal.h.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)